feat: html vscode script for buttons and links [IDE-375] [IDE-367] #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/html-vscode-script
branch
from
30a9514 to
2138477
Compare
cat2608
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
🚀 Tested it with snyk/snyk-ls#531 and all the interactions work as expected! Thank you!
teodora-sandu
changed the title
teodora-sandu
force-pushed
the
feat/html-vscode-script
branch
2 times, most recently
from
bb3068e to
2138477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the interactions for clicking on the Data Flow links and the inline ignore buttons at the bottom of the footer in VSCode. It duplicates some of the code in
codeSuggestionWebviewScriptbut most of the code in that script right now is insnyk-lssince it's only HTML interactions. Eventually we can delete that file and I made a decision not to refactor it and make the two scripts use common code because it would mean more work to include the common scripts across the two.To manually test run
npm run buildand then run the extension.There aren't any unit tests for this code at the moment so not adding any tests.
Tickets:
Checklist
Screenshots / GIFs
Screen.Recording.2024-06-04.at.10.18.58.mov