Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower strictness of custom endpoint regex validation [IDE-352] #461

Merged
merged 1 commit into from
May 23, 2024

Conversation

teodora-sandu
Copy link
Contributor

@teodora-sandu teodora-sandu commented May 23, 2024

Description

Lowers the strictness of the regex validation for the custom endpoint so that it just checks that it starts with api and ends with (snyk|snykgov).io.

Can see all the single tenant endpoints here. The API endpoint for this bug can be found here.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Before:
Screenshot 2024-05-23 at 09 06 49

After:
Screenshot 2024-05-23 at 09 09 18
Screenshot 2024-05-23 at 09 09 15

@teodora-sandu teodora-sandu requested a review from a team as a code owner May 23, 2024 08:13
@teodora-sandu teodora-sandu merged commit 78f64cb into main May 23, 2024
7 checks passed
@teodora-sandu teodora-sandu deleted the fix/custom-endpoint-validation-strictness branch May 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants