refactor: initialisation of feature flag status [IDE-346] #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat2608
changed the title
teodora-sandu
force-pushed
the
fix/feature-flag-status-init
branch
2 times, most recently
from
894d391 to
d25dbc9
Compare
teodora-sandu
changed the title
teodora-sandu
force-pushed
the
fix/feature-flag-status-init
branch
from
d25dbc9 to
452b7e2
Compare
teodora-sandu
force-pushed
the
fix/feature-flag-status-init
branch
3 times, most recently
from
14ae1a5 to
a4c9442
Compare
teodora-sandu
commented
Jun 13, 2024
| @@ -1,10 +1,9 @@ | |||
| # Snyk Security Changelog | |||
|
|
|||
| ## [2.12.2] | |||
There was a problem hiding this comment.
We don't need a new version for each PR, just need to add changelog messages to the next version after the latest release
bastiandoetsch
approved these changes
Jun 14, 2024
teodora-sandu
force-pushed
the
fix/feature-flag-status-init
branch
from
a4c9442 to
85e2325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the logic used for initialising the feature flag status at startup.
To test, run the VSCode sandbox then:
snykCodeConsistentIgnoressnykCodeConsistentIgnores(e.g.ide-consistent-ignores-test)Note! We are aware of a bug where changing the organisation in Snyk Settings does not trigger an update of the organisation in LS and so the feature flag status doesn't change because the org hasn't, as far as the command in LS is aware.
Checklist