feat: conditionally render LSP template [IDE-233] #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/snyk/snykCode/codeSettings.ts
Outdated
| @@ -43,6 +44,7 @@ export class CodeSettings implements ICodeSettings { | |||
| } | |||
| await this.contextService.setContext(SNYK_CONTEXT.CODE_ENABLED, codeEnabled); | |||
| await this.contextService.setContext(SNYK_CONTEXT.CODE_LOCAL_ENGINE_ENABLED, localCodeEngineEnabled); | |||
| this.config.setFeatureFlag(FEATURE_FLAGS.consistentIgnores, codeEnabled); | |||
There was a problem hiding this comment.
I'm not sure if this is the right place to put it, ideally we would have a more global way of updating feature flag status even if this is for Snyk Code
There was a problem hiding this comment.
You're right, this is not the correct implementation.
Working on it 💪
teodora-sandu
approved these changes
May 20, 2024
- Update `CodeSettings` to set the `consistentIgnores` feature flag based LSP command. - Modify unit tests to mock `setFeatureFlag` method in `IConfiguration`.
cat2608
force-pushed
the
feat/IDE-233-render-lsp-template
branch
from
e84831b to
1994154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the feature flag status to render Issue details provided by Language Server.
Note: styling and template updates will be addressed in next PRs
Checklist
Screenshots / GIFs