fix: add flag to track encoding state of example lines #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat2608
force-pushed
the
fix/HEAD-1231-avoid-re-encoding-example-lines
branch
from
5bbe2bb to
4ba5125
Compare
acke
approved these changes
Feb 3, 2024
Ensure `htmlEncoder` function only encodes each line once, preventing double encoding on subsequent function calls.
cat2608
force-pushed
the
fix/HEAD-1231-avoid-re-encoding-example-lines
branch
from
4ba5125 to
d203832
Compare
bastiandoetsch
approved these changes
Feb 5, 2024
bastiandoetsch
deleted the
fix/HEAD-1231-avoid-re-encoding-example-lines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
isExampleLineEncodedboolean property toCommitChangeLinetype to ensure that thehtmlEncoderfunction only encodes each line once, preventing double encoding on subsequent function calls.Checklist
Screenshots / GIFs
🐛 Before
before.mp4
✅ After
after.mp4