Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct visibility toggling of details section [HEAD-1172] #418

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Dec 22, 2023

Description

  • Resolved an issue where the suggestion details section in the webview was not properly toggling visibility.
  • Replaced the previous inline styling method with a CSS class.
  • Implement caching for frequently accessed DOM elements.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Before After
before after

- Resolved an issue where the suggestion details section in the webview was not properly toggling visibility.
- Replaced the previous inline styling method with a CSS class.
@cat2608 cat2608 requested a review from a team as a code owner December 22, 2023 10:08
@cat2608 cat2608 changed the title fix: correct visibility toggling of details section [HEAD-559] fix: correct visibility toggling of details section [HEAD-1172] Dec 22, 2023
@PeterSchafer PeterSchafer merged commit d59c9d0 into main Dec 22, 2023
6 checks passed
@PeterSchafer PeterSchafer deleted the fix/HEAD-559-details-visibility branch December 22, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants