Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add detail section to code webview [HEAD-559] #405

Merged
merged 6 commits into from
Dec 20, 2023
Merged

feat: add detail section to code webview [HEAD-559] #405

merged 6 commits into from
Dec 20, 2023

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Dec 11, 2023 •
edited
Loading

Description

This PR adds the details information to the Webview panel

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Before After
HIGH-example-before-no-details HIGH-example-after-just-details
LOW-example-before-no-details LOW-example-after-details-with-prevention png
suggestion-details-panel.mp4

@cat2608 cat2608 force-pushed the feat/HEAD-559-add-issue-details branch 2 times, most recently from ba1889d to 22593b3 Compare December 14, 2023 11:29
@cat2608 cat2608 marked this pull request as ready for review December 14, 2023 11:29
@cat2608 cat2608 requested a review from a team as a code owner December 14, 2023 11:29
@cat2608 cat2608 force-pushed the feat/HEAD-559-add-issue-details branch from 22593b3 to f301a28 Compare December 14, 2023 11:44
@bastiandoetsch
Copy link
Contributor

Please add a changelog entry :)

@cat2608 cat2608 force-pushed the feat/HEAD-559-add-issue-details branch from f301a28 to e7875e4 Compare December 15, 2023 07:10
bastiandoetsch
bastiandoetsch approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for now, let's coordinate & wait for UX, though :)

@cat2608
feat: add collapsible section for suggestion details
04fa0f4 
- Added a 'Read more' button to toggle the display of full suggestion details.
@cat2608
chore: add CHANGELOG
8667f0d
@cat2608 cat2608 force-pushed the feat/HEAD-559-add-issue-details branch from 0389f50 to 8667f0d Compare December 18, 2023 21:13
@PeterSchafer PeterSchafer merged commit 082437d into main Dec 20, 2023
6 checks passed
@PeterSchafer PeterSchafer deleted the feat/HEAD-559-add-issue-details branch December 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cat2608 @bastiandoetsch @PeterSchafer