Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom base url configuration for dev work [ROAD-209] #36

Merged
merged 1 commit into from
Aug 16, 2021
Merged

feat: allow custom base url configuration for dev work [ROAD-209] #36

merged 1 commit into from
Aug 16, 2021

Conversation

michelkaporin
Copy link
Contributor

@michelkaporin michelkaporin commented Aug 4, 2021 •
edited
Loading

  • Add custom base url for Snyk Code
  • Add custom token for Snyk Code url
  • Remove replaceAll function as Node.js runtime differs when running extension with remote folder.

Base automatically changed from refactor/extract-code to master August 4, 2021 10:54
@michelkaporin michelkaporin marked this pull request as ready for review August 4, 2021 11:03
@michelkaporin michelkaporin requested review from Arvi3d, pavel-snyk and a team August 4, 2021 11:03
Arvi3d
Arvi3d requested changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@Arvi3d Arvi3d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to debug this version, but it did not work for me.
First i get this popup:
Screenshot 2021-08-06 at 18 08 44
But, strangly, it seems loaded anyways. After that settings button does not work for me.

Sidebar shows this (with button not responsive ):
Screenshot 2021-08-06 at 18 11 54

@michelkaporin
Copy link
Contributor Author

@Arvi3d not sure where the issues come from. Have you uninstalled your local Snyk extension before running this branch in the debug mode?

Feel free to reach out to me on slack to get a packaged VSIX for testing.

@michelkaporin michelkaporin requested a review from Arvi3d August 11, 2021 06:16
@michelkaporin michelkaporin force-pushed the feat/custom-url branch 2 times, most recently from 1f5cc32 to e52fea9 Compare August 13, 2021 09:24
pavel-snyk
pavel-snyk approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Arvi3d
Arvi3d approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@Arvi3d Arvi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you Michel!

@Arvi3d
Copy link
Contributor

Arvi3d commented Aug 15, 2021

@michelkaporin could you please ping me once this version is published on a marketplace. I'll update our documentation for developers with this new feature

@michelkaporin
Copy link
Contributor Author

@Arvi3d will do, thank you.

pavel-snyk
pavel-snyk approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michelkaporin michelkaporin merged commit 94648e7 into master Aug 16, 2021
@michelkaporin michelkaporin deleted the feat/custom-url branch August 16, 2021 11:18
@di55er di55er mentioned this pull request Dec 22, 2023
Closed
@johnrk johnrk mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-snyk pavel-snyk pavel-snyk approved these changes

@Arvi3d Arvi3d Arvi3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelkaporin @Arvi3d @pavel-snyk