Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add view navigation integration test [ROAD-189] #32

Merged
merged 1 commit into from
Jul 28, 2021
Merged

test: add view navigation integration test [ROAD-189] #32

merged 1 commit into from
Jul 28, 2021

Conversation

michelkaporin
Copy link
Contributor

@michelkaporin michelkaporin commented Jul 27, 2021 •
edited
Loading

  • Adds a single test to check if Features webview is shown after authentication. Due to time constraints other tests were not added however the test suite is extensible.
  • Corrects webview class name for Features webview
  • Configuration setting to return undefined instead of null to communicate setting absence and not a null pointer.

@michelkaporin michelkaporin requested a review from pavel-snyk July 27, 2021 11:39
@michelkaporin michelkaporin changed the title test: add view navigation integration test test: add view navigation integration test [ROAD-189] Jul 27, 2021
pavel-snyk
pavel-snyk approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michelkaporin michelkaporin merged commit a3bf788 into master Jul 28, 2021
@michelkaporin michelkaporin deleted the test/view-navigation branch July 29, 2021 12:03
@di55er di55er mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-snyk pavel-snyk pavel-snyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michelkaporin @pavel-snyk