fix: Snyk reported issues

package.json

@@ -424,13 +424,13 @@
     "@sentry/tracing": "^6.16.1",
     "@snyk/code-client": "^4.9.1",
     "analytics-node": "^4.0.1",
-    "axios": "^0.21.1",
+    "axios": "^0.26.1",
     "glob": "^7.2.0",
     "htmlparser2": "^7.2.0",
     "http-proxy-agent": "^5.0.0",
     "https-proxy-agent": "^5.0.0",
     "lodash": "^4.17.21",
-    "marked": "^3.0.2",
+    "marked": "^4.0.13",
     "open": "^7.4.2",
     "rxjs": "^7.3.0",
     "string-argv": "^0.3.1",

src/snyk/common/error/errorHandler.ts

@@ -19,14 +19,14 @@ export class ErrorHandler {
   ): Promise<void> {
     await contextService.setContext(SNYK_CONTEXT.ERROR, SNYK_ERROR_CODES.BLOCKING);
     loadingBadge.setLoadingBadge(true);
-    this.handle(error, logger);
+    ErrorHandler.handle(error, logger);
   }
 
   /**
    * Should be used to log locally and report error event remotely.
    */
   static handle(error: Error | unknown, logger: ILog, message?: string, tags?: Tags): void {
-    const errorStr = this.stringifyError(error);
+    const errorStr = ErrorHandler.stringifyError(error);
     logger.error(message ? `${message}. ${errorStr}` : errorStr);
     ErrorReporter.capture(error, tags);
   }

src/snyk/snykCode/analyzer/analyzer.ts

@@ -244,6 +244,7 @@ class SnykCodeAnalyzer implements ISnykCodeAnalyzer {
   static isIssueVisible(configuration: IConfiguration, isSecurityType: boolean, severity: AnalysisSeverity): boolean {
     if (isSecurityType && !configuration.getFeaturesConfiguration()?.codeSecurityEnabled) {
       return false;
+      // deepcode ignore DuplicateIfBody: readability
     } else if (!isSecurityType && !configuration.getFeaturesConfiguration()?.codeQualityEnabled) {
       return false;
     }

src/snyk/snykCode/error/snykCodeErrorHandler.ts

@@ -138,7 +138,8 @@ export class SnykCodeErrorHandler extends ErrorHandler implements ISnykCodeError
     this.logger.error(`Connection error to Snyk Code. Try count: ${this.transientErrors + 1}.`);
     if (this.transientErrors > MAX_CONNECTION_RETRIES) {
       this._connectionRetryLimitExhausted = true;
-      return this.generalErrorHandler(error, options, callback);
+      this.generalErrorHandler(error, options, callback);
+      return;
     }
 
     this.transientErrors += 1;

src/snyk/snykCode/views/falsePositive/falsePositiveWebviewScript.ts

@@ -128,6 +128,7 @@
   document.getElementById('cancel')?.addEventListener('click', close);
   document.getElementById('send')?.addEventListener('click', send);
 
+  // deepcode ignore InsufficientValidation: Content Security Policy applied in provider
   window.addEventListener('message', event => {
     const { type, args } = event.data;
     switch (type) {

src/snyk/snykCode/views/suggestion/codeSuggestionWebviewScript.ts

@@ -247,6 +247,7 @@
   document.getElementById('ignore-file-issue')!.addEventListener('click', ignoreIssue.bind(false));
   document.getElementById('report-fp')?.addEventListener('click', openFalsePositiveCode);
 
+  // deepcode ignore InsufficientValidation: Content Security Policy applied in provider
   window.addEventListener('message', event => {
     const { type, args } = event.data;
     switch (type) {

src/snyk/snykOss/services/ossService.ts

@@ -1,4 +1,4 @@
-import marked from 'marked';
+import * as marked from 'marked';
 import { Subject } from 'rxjs';
 import { IExtension } from '../../base/modules/interfaces';
 import { CliDownloadService } from '../../cli/services/cliDownloadService';
@@ -175,7 +175,7 @@ export class OssService extends CliService<OssResult> {
   ): Promise<OssIssueCommandArg> {
     return new Promise((resolve, reject) => {
       const matchingIdVulnerabilities = allVulnerabilities.filter(v => v.id === vulnerability.id);
-      marked(vulnerability.description, (err, overviewHtml) => {
+      marked.parse(vulnerability.description, (err, overviewHtml) => {
         if (err) {
           return reject(err);
         }

src/snyk/snykOss/services/vulnerabilityCount/ossVulnerabilityCountService.ts

@@ -67,7 +67,7 @@ export class OssVulnerabilityCountService implements Disposable {
     // Subscribe to OSS scan finished updates
     this.ossScanFinishedSubscription = this.ossService.scanFinished$.subscribe(() => this.processActiveEditor());
 
-    [JAVASCRIPT, TYPESCRIPT, PJSON, HTML].map(language => {
+    [JAVASCRIPT, TYPESCRIPT, PJSON, HTML].forEach(language => {
       const provider = new VulnerabilityCodeActionProvider(
         this.ossService,
         this.vulnerabilityCountProvider,

src/snyk/snykOss/views/suggestion/ossSuggestionWebviewScript.ts

@@ -240,6 +240,7 @@
     }`;
   }
 
+  // deepcode ignore InsufficientValidation: Content Security Policy applied in provider
   window.addEventListener('message', event => {
     const { type, args } = event.data;
     switch (type) {

src/test/unit/snykOss/services/vulnerabilityCount/parsers/htmlParser.test.ts

@@ -72,7 +72,7 @@ suite('HTML Parser', () => {
     parser = new HtmlParser();
   });
 
-  testScenarios.map(scenario => {
+  testScenarios.forEach(scenario => {
     test(`Extracts ${scenario.name} package and version`, () => {
       const packages = parser.getModules('foo', `<script src="${scenario.url}"></script>`);