fix: check for empty Url

snyk · Oct 25, 2024 · 5a60b4b · 5a60b4b
1 parent e8d39c5
commit 5a60b4b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/snyk/base/services/authenticationService.ts b/src/snyk/base/services/authenticationService.ts
@@ -92,7 +92,10 @@ export class AuthenticationService implements IAuthenticationService {
     } else {
       if (!this.validateToken(token)) return Promise.reject(new Error('The entered token has an invalid format.'));
 
-      await this.configuration.setEndpoint(apiUrl);
+      if (apiUrl !== null && apiUrl !== undefined && apiUrl.trim().length > 0) {
+        await this.configuration.setEndpoint(apiUrl);
+      }
+
       await this.configuration.setToken(token);
       await this.contextService.setContext(SNYK_CONTEXT.AUTHENTICATING, false);
       await this.contextService.setContext(SNYK_CONTEXT.LOGGEDIN, true);

diff --git a/src/test/unit/base/services/authenticationService.test.ts b/src/test/unit/base/services/authenticationService.test.ts
@@ -182,7 +182,7 @@ suite('AuthenticationService', () => {
       const apiUrl = 'https://api.snyk.io';
 
       await service.updateTokenAndEndpoint(oauthTokenString, apiUrl);
-      sinon.assert.calledWith(setEndpointSpy, apiUrl)
+      sinon.assert.calledWith(setEndpointSpy, apiUrl);
       sinon.assert.calledWith(setTokenSpy, oauthTokenString);
     });