Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Dockerfile to help with using snyk-to-html in pipelines #54

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

garethr
Copy link
Contributor

@garethr garethr commented Oct 29, 2019

Packaging snyk-to-html as a Docker image makes using the tool in places
where installing a full Node toolchain is problematic or annoying. The
image also aims to make usage easier by outputting the html on stdout,
rather than writing a file to disk.

Using the -o and -i options the image can be used to read and/or write from
files on disk as well.

Packaging snyk-to-html as a Docker image makes using the tool in places
where installing a full Node toolchain is problematic or annoying. The
image also aims to make usage easier by outputting the html on stdout,
rather than writing a file to disk.

Using the -o and -i options the image can be used to read and/or write from
files on disk as well.
Copy link
Contributor

@gitphill gitphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could add to README something like:

Using Docker

docker build -t snyk-to-html .
snyk test --json | docker run --rm -i snyk-to-html

@garethr
Copy link
Contributor Author

garethr commented Nov 8, 2019

If this works for you I'd like to get this set up to build and push to the snyk namespace on Docker Hub. so snyk/snyk-to-html presumably. This would require someone with access to create a token from Docker Hub and then encrypt it in the Travis config. I can add an update to the Travis config which will build and push the image as time permits. Alternatively, we could move this to https://github.com/snyk/snyk-images which is building the new image set.

Happy to update the docs when we settle on the best approach. I'd prefer not to just leave users to build the image and for us to build once.

@lili2311 lili2311 merged commit 69e0db9 into master Jan 9, 2020
@snyksec
Copy link

snyksec commented Jan 27, 2020

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants