Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support pipenv empty packages #192

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: support pipenv empty packages #192

merged 1 commit into from
Oct 25, 2022
+4 −1

Conversation

xzhou-snyk
Copy link
Contributor

This PR supports the special case when in a Pipfile there is no [packages] section.

@xzhou-snyk xzhou-snyk requested a review from a team as a code owner October 21, 2022 15:53
klesniewski
klesniewski approved these changes Oct 25, 2022
View reviewed changes
Copy link

@klesniewski klesniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@xzhou-snyk xzhou-snyk merged commit 43d4b85 into master Oct 25, 2022
@xzhou-snyk xzhou-snyk deleted the fix/support-pipenv-with-empty-packages branch October 25, 2022 11:33
@snyksec
Copy link

snyksec commented Oct 25, 2022

🎉 This PR is included in version 1.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xzhou-snyk xzhou-snyk mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admons admons admons approved these changes

@klesniewski klesniewski klesniewski approved these changes

@orsagie orsagie Awaiting requested review from orsagie orsagie was automatically assigned from snyk/loki

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xzhou-snyk @snyksec @klesniewski @admons