Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cyclic deps support for dverbose #173

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

MarcusArdelean
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Cyclic dependencies were not handled until now while using the -Dverbose flag. The PR is adding support for cyclic dependencies by keeping track of the already visited packages and storing them in an ancestry list.

@MarcusArdelean MarcusArdelean self-assigned this Apr 24, 2024
@MarcusArdelean MarcusArdelean requested a review from a team as a code owner April 24, 2024 12:44
Copy link
Contributor

@orsagie orsagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcusArdelean MarcusArdelean merged commit f32664a into master Apr 24, 2024
4 checks passed
@MarcusArdelean MarcusArdelean deleted the fix/dverbose-cyrcular-deps branch April 24, 2024 12:53
@snyksec
Copy link

snyksec commented Apr 24, 2024

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants