feat: improve the CSS for the OSS suggestion panel [IDE-285] #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/html-oss-intellij-css
branch
from
305499e to
96d5b69
Compare
ShawkyZ
pushed a commit
that referenced
this pull request
Jul 10, 2024
ShawkyZ
pushed a commit
that referenced
this pull request
Jul 10, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some base styling from
vscode-extensionso that we have a reasonably consistent styling across all IDEs and have the building blocks ready for when we render the HTML in IntelliJ. IntelliJ will need some custom styling for colours and fonts but other than that the LS is responsible for the majority of the styling.We also have snyk/vscode-extension#486 which we will need to merge once the CLI releases a stable version including this version of the LS. Has been tested with both
mainand that branch ofvscode-extensionNote To test, you must run
npm run buildinvscode-extensionto make sure the correct CSS is applied.Checklist
🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs
main