fix: redirect stdout to stderr for browser pkg (#689)

Co-authored-by: Berkay Beraby <[email protected]>

domain/ide/command/open_browser.go

@@ -21,7 +21,6 @@ import (
 
 	"github.com/rs/zerolog"
 
-	"github.com/snyk/go-application-framework/pkg/auth"
 	"github.com/snyk/snyk-ls/internal/types"
 )
 
@@ -37,6 +36,6 @@ func (cmd *openBrowserCommand) Command() types.CommandData {
 func (cmd *openBrowserCommand) Execute(ctx context.Context) (any, error) {
 	url := cmd.command.Arguments[0].(string)
 	cmd.logger.Debug().Str("method", "openBrowserCommand.Execute").Msgf("opening browser url %s", url)
-	auth.OpenBrowser(url)
+	types.DefaultOpenBrowserFunc(url)
 	return nil, nil
 }

go.mod

@@ -20,6 +20,7 @@ require (
 	github.com/otiai10/copy v1.14.0
 	github.com/pact-foundation/pact-go v1.10.0
 	github.com/pingcap/errors v0.11.4
+	github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8
 	github.com/pkg/errors v0.9.1
 	github.com/puzpuzpuz/xsync v1.5.2
 	github.com/puzpuzpuz/xsync/v3 v3.4.0
@@ -98,7 +99,6 @@ require (
 	github.com/pelletier/go-toml/v2 v2.2.2 // indirect
 	github.com/perimeterx/marshmallow v1.1.5 // indirect
 	github.com/pjbgf/sha1cd v0.3.0 // indirect
-	github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect

internal/types/command.go

@@ -18,9 +18,9 @@ package types
 
 import (
 	"context"
+	"github.com/pkg/browser"
+	"os"
 	"sync"
-
-	"github.com/snyk/go-application-framework/pkg/auth"
 )
 
 const (
@@ -47,7 +47,10 @@ const (
 )
 
 var (
-	DefaultOpenBrowserFunc = func(url string) { auth.OpenBrowser(url) }
+	DefaultOpenBrowserFunc = func(url string) {
+		browser.Stdout = os.Stderr
+		_ = browser.OpenURL(url)
+	}
 )
 
 type Command interface {