fix: adds large file support to bufferToSha1 method #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristinaDara
approved these changes
Feb 20, 2024
|
🎉 This PR is included in version 6.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds large file support to
bufferToSha1method.Where should the reviewer start?
The
bufferToSha1method was failing as theupdatemethod of theCrypto.Hashobject usesBuffer.allocwhich has a limitation of 2G. Any JARs bigger than this would cause aRangeErrorinNode.This fix uses the stream interface of
Crypto.Hashto stream data for large files in order to generate the Sha1 digest.How should this be manually tested?
Scan any container with a Maven project that contains one or more JAR over 2G in size.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/SUP-1997