refactor: do not show the snyk-report-tab on build results that do not contain the snyk task #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…t contain the snyk task
rhyskoedijk
force-pushed
the
feature/define-supports-tasks
branch
from
b9bc066
to
c688d1c
Compare
|
@j-luong any chance this could be approved? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "Snyk Report" tab shows on all build results, even if the build pipeline does not actually use the Snyk task. If the task is never run, the tab renders nothing and just clutters the build results.
This change restricts the tab to only show for builds that ran the Snyk task.
^ this build does not contain the Snyk task.