Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use latest argo-rollouts installation #1268

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

snaftaly
Copy link
Contributor

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

use latest argo-rollouts installation in integration tests.

Notes for the reviewer

Issue in argo-rollouts that were causing tests to fail in eks and aks was fixed. Therefore, the latest version can be used again.

@snaftaly snaftaly force-pushed the test/get-latest-argo-rollouts-with-bug-fix branch from 02cf4ef to f51eb74 Compare February 19, 2023 17:03
//TODO: We pin to a earlier version due to a bug in Argo Rollout, we will revert to latest once the bug is fixed.
// https://github.com/argoproj/argo-rollouts/issues/2568
'https://github.com/argoproj/argo-rollouts/releases/download/v1.3.2/install.yaml',
'https://github.com/argoproj/argo-rollouts/releases/latest/download/install.yaml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@snaftaly snaftaly marked this pull request as ready for review February 20, 2023 10:13
@snaftaly snaftaly requested a review from a team as a code owner February 20, 2023 10:13
Issue in argo-rollouts that were causing tests to fail in eks
and aks was fixed. Therefore, the latest version can be used
again.
@snaftaly snaftaly force-pushed the test/get-latest-argo-rollouts-with-bug-fix branch from f51eb74 to b20a635 Compare February 20, 2023 10:21
@snaftaly snaftaly merged commit 64ee33f into staging Feb 21, 2023
@snaftaly snaftaly deleted the test/get-latest-argo-rollouts-with-bug-fix branch February 21, 2023 12:18
@snyk-deployer
Copy link
Collaborator

🎉 This PR is included in version 1.104.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants