Several improvements on acceptance tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 146 146
Lines 3314 3314
=======================================
Hits 2222 2222
Misses 842 842
Partials 250 250 |
wbeuil
reviewed
Jan 6, 2021
- Add filter on aws_instance test - Add terraform locks - Do not run terraform init if already done previously - Do not use chdir in tests (it could cause race if we want to switch to parallel tests, uses --from arg instead) - Handle terraform destroy errors
eliecharra
force-pushed
the
improve_acc_tests
branch
from
e558afb
to
c83b538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description