Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive on field InstanceInitiatedShutdownBehavior #413

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

sundowndev
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #403
❓ Documentation no

Description

We figured out that this field is actually not supported by the provider. We decided to simply ignore it for the moment.

@sundowndev sundowndev added the kind/bug Something isn't working label Apr 7, 2021
@sundowndev sundowndev added this to the v0.7.1 milestone Apr 7, 2021
@sundowndev sundowndev marked this pull request as ready for review April 7, 2021 16:55
@sundowndev sundowndev requested a review from a team as a code owner April 7, 2021 16:55
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #413 (1048d8b) into v0.7 (d81d0a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v0.7     #413   +/-   ##
=======================================
  Coverage   69.43%   69.43%           
=======================================
  Files         282      282           
  Lines        6050     6050           
=======================================
  Hits         4201     4201           
  Misses       1496     1496           
  Partials      353      353           
Impacted Files Coverage Ξ”
pkg/resource/aws/aws_instance.go 100.00% <ΓΈ> (ΓΈ)

@eliecharra eliecharra merged commit 6d11ad2 into v0.7 Apr 8, 2021
@eliecharra eliecharra deleted the fix/EC2instance2 branch April 8, 2021 08:20
@sundowndev sundowndev mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants