Add resource factory #389
Merged
Add resource factory #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 70.23% 70.25% +0.01%
==========================================
Files 281 282 +1
Lines 6149 6277 +128
==========================================
+ Hits 4319 4410 +91
- Misses 1476 1503 +27
- Partials 354 364 +10
|
eliecharra
force-pushed
the
add_resource_factory
branch
2 times, most recently
from
17fe6cc
to
4dcd669
Compare
eliecharra
force-pushed
the
add_resource_factory
branch
from
4dcd669
to
2b71c8e
Compare
wbeuil
reviewed
Apr 7, 2021
| @@ -118,12 +123,21 @@ func TestAwsInstanceBlockDeviceResourceMapper_Execute(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| func(factory *terraform.MockResourceFactory) { | |||
| factory.On("CreateResource", mock.Anything, "aws_ebs_volume").Times(2).Return(nil, nil) | |||
There was a problem hiding this comment.
Just FYI, you can use here Twice() instead of Times(2) but no need to change it.
There was a problem hiding this comment.
Yeah I know but I prefer to always use Times
There was a problem hiding this comment.
If i == 1 you use Once and if i > 1 Times(i) ?
There was a problem hiding this comment.
Yeah and I was wondering myself if I should use Times everywhere
There was a problem hiding this comment.
Indeed, it is more explicit.
wbeuil
approved these changes
Apr 7, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description