when sns subscription is pending prevent crash and show an alert #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 69.21% 69.19% -0.03%
==========================================
Files 280 280
Lines 5955 5966 +11
==========================================
+ Hits 4122 4128 +6
- Misses 1476 1481 +5
Partials 357 357
|
eliecharra
reviewed
Mar 17, 2021
wbeuil
reviewed
Mar 17, 2021
moadibfr
force-pushed
the
fix/sns_sub_pending
branch
2 times, most recently
from
128a89b
to
1201b47
Compare
eliecharra
approved these changes
Mar 17, 2021
wbeuil
previously approved these changes
Mar 17, 2021
eliecharra
previously approved these changes
Mar 17, 2021
moadibfr
force-pushed
the
fix/sns_sub_pending
branch
from
f333f4d
to
53103f6
Compare
eliecharra
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNS Topic subscription can be pending confirmation and they have an invalid arn in this case.
this pr handle this case without crashing. instead it will produce an alert to inform user that drift for this subs will be ignored