Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle enumeration error from github provider #308

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues none
❓ Documentation no

Description

Add support for enumeration errors alert for github provider.

⚠️ It also changes documentations links to use docs.driftctl.com brand new website, and thus this PR should be merged when the new website will be ready.

@wbeuil Wording review required πŸ™πŸ»

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Mar 2, 2021
@eliecharra eliecharra requested a review from a team March 2, 2021 10:41
lotoussa
lotoussa previously approved these changes Mar 2, 2021
Copy link
Contributor

@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, lgtm !

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #308 (cb986f5) into main (37b8831) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   68.96%   69.06%   +0.09%     
==========================================
  Files         277      277              
  Lines        5849     5867      +18     
==========================================
+ Hits         4034     4052      +18     
  Misses       1462     1462              
  Partials      353      353              
Impacted Files Coverage Ξ”
pkg/cmd/scan/output/console.go 100.00% <100.00%> (ΓΈ)
pkg/remote/resource_enumeration_error_handler.go 97.22% <100.00%> (+2.77%) ⬆️

@eliecharra eliecharra marked this pull request as ready for review March 3, 2021 09:32
@eliecharra eliecharra changed the title Handle enumeration error from multiples providers Handle enumeration error from github provider Mar 3, 2021
@eliecharra eliecharra merged commit af5a11f into main Mar 3, 2021
@eliecharra eliecharra deleted the handle_github_listing_error branch March 3, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants