Add github membership #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 68.90% 68.89% -0.01%
==========================================
Files 259 262 +3
Lines 5554 5607 +53
==========================================
+ Hits 3827 3863 +36
- Misses 1398 1410 +12
- Partials 329 334 +5
|
wbeuil
suggested changes
Mar 1, 2021
| raw := raw | ||
| res, err := decodeMembership(&raw) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "error when deserializing github_team %+v : %+v", raw, err) |
There was a problem hiding this comment.
Nice catch, fixed
As I said in the PR description :
|
|
Sorry forgot what you said in the description of the PR. Then just the small typo and I'm good with it |
eliecharra
force-pushed
the
add_github_membership
branch
from
f9d7ca6
to
d731125
Compare
eliecharra
force-pushed
the
add_github_membership
branch
from
d731125
to
ba8f950
Compare
wbeuil
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No acceptance for this one guys as I didn't find a simple way to accept invitation within acceptance test