-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github membership #304
Conversation
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 68.90% 68.89% -0.01%
==========================================
Files 259 262 +3
Lines 5554 5607 +53
==========================================
+ Hits 3827 3863 +36
- Misses 1398 1410 +12
- Partials 329 334 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo and wonder why you didn't make any acceptance tests ?
raw := raw | ||
res, err := decodeMembership(&raw) | ||
if err != nil { | ||
return nil, errors.Wrapf(err, "error when deserializing github_team %+v : %+v", raw, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... github_membership
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, fixed
As I said in the PR description :
|
Sorry forgot what you said in the description of the PR. Then just the small typo and I'm good with it |
f9d7ca6
to
d731125
Compare
d731125
to
ba8f950
Compare
Description
No acceptance for this one guys as I didn't find a simple way to accept invitation within acceptance test