add support for sns_topic_policy #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 69.83% 69.81% -0.03%
==========================================
Files 206 211 +5
Lines 4648 4740 +92
==========================================
+ Hits 3246 3309 +63
- Misses 1145 1166 +21
- Partials 257 265 +8
|
eliecharra
reviewed
Feb 5, 2021
...923_user-updates-topic-arn_aws_sns_eu-west-3_526954929923_user-updates-topic.res.golden.json
Outdated
Show resolved
Hide resolved
moadibfr
force-pushed
the
fea/sns_topic_policy
branch
from
b6d7713
to
48a0dd3
Compare
wbeuil
suggested changes
Feb 5, 2021
| "Id": "arn:aws:sns:us-east-1:526954929923:my-topic-with-policy", | ||
| "Policy": "{\"Id\":\"__default_policy_ID\",\"Statement\":[{\"Action\":[\"SNS:Subscribe\",\"SNS:SetTopicAttributes\",\"SNS:RemovePermission\",\"SNS:Receive\",\"SNS:Publish\",\"SNS:ListSubscriptionsByTopic\",\"SNS:GetTopicAttributes\",\"SNS:DeleteTopic\",\"SNS:AddPermission\"],\"Condition\":{\"StringEquals\":{\"AWS:SourceOwner\":[]}},\"Effect\":\"Allow\",\"Principal\":{\"AWS\":\"*\"},\"Resource\":\"arn:aws:sns:us-east-1:526954929923:my-topic-with-policy\",\"Sid\":\"__default_statement_ID\"}],\"Version\":\"2012-10-17\"}" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Since it's only for the state reader, we can have here and inside the tfstate only the policy. We don't need the parent topic. I would just delete them manually.
| policies := make([]resource.Resource, 0) | ||
|
|
||
| for _, value := range topicList { | ||
| policy, err := decodeSNSTopicPolicy(value) |
There was a problem hiding this comment.
We should shadow the variable here from now on to be consistent with what @elie has done on his last PR.
for _, value := range topicList {
value := value
policy, err := decodeSNSTopicPolicy(value)
There was a problem hiding this comment.
it does not seem to trigger linter error, I'm wondering if this is required there
moadibfr
force-pushed
the
fea/sns_topic_policy
branch
3 times, most recently
from
8d6f280
to
0f8361d
Compare
modify sns_topic support so that we create sns_topic_policy for inline policy
moadibfr
force-pushed
the
fea/sns_topic_policy
branch
from
0f8361d
to
7041cf1
Compare
eliecharra
approved these changes
Feb 5, 2021
wbeuil
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add support for sns_topic_policy
modify sns_topic support so that we create sns_topic_policy for inline
policy