More readable aws resources scan output

[lotoussa]

Q	A
🐛 Bug fix?	no
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues	issue 79
❓ Documentation	Change the doc if there's an example of scan output in it, to match with the new output.

Description

ISSUE 79: first lotoussa issue.

I first corrected the scan output of route53 resources as requested in issue 79.
Then I updated the console output (which handle aws resources output in general).
Updated the tests.

The PR is probably still in progress, because there's others aws resources containing string method that need to return either ID or adapted humanString, but i want to make a brief point of that with someone of the team.
(file concerned: aws_route_table_association_ext, aws_route_ext, aws_security_group_rule_ext)

[wbeuil]

Congrats for your first PR Louis !

As Elie told me more than once, try to keep your PR as small as possible with the issue you're working on.

As for the description of your PR, I didn't understand all of what you wrote. What is SIP ? Can you "re-read" and thus edit so that we can fully understand (or maybe I'm solo on this one and shame on me to not understand ^^).

[eliecharra]

The PR title should be reworked to something clear enough to be understandable by our users (and by us) as it will be used as it in the changelog : https://github.com/cloudskiff/driftctl/releases

[eliecharra]

New feature? | no

Actually the issue is flagged as a new feature

[eliecharra]

You should update stringer usage in diff output too (not only for deleted and unmanaged resources)

[codecov]

Codecov Report

Merging #189 (a956cf9) into main (2b51226) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   69.77%   69.79%   +0.01%     
==========================================
  Files         215      215              
  Lines        4811     4813       +2     
==========================================
+ Hits         3357     3359       +2     
  Misses       1184     1184              
  Partials      270      270              

Impacted Files	Coverage Δ
pkg/cmd/scan/output/console.go	100.00% <100.00%> (ø)
pkg/resource/aws/aws_route53_record_ext.go	83.33% <100.00%> (+3.33%)	⬆️
pkg/resource/aws/aws_route53_zone_ext.go	100.00% <100.00%> (ø)

[lotoussa]

I'll refresh goldenfiles another day, description PR and resolve others conversations too.

[eliecharra]

A way better 👍🏻 I still have small remarks

[eliecharra]

Awesome 👍🏻

Approved by engineering

[wbeuil]

@all-contributors please add @lotoussa for code, doc

[allcontributors]

@wbeuil

I've put up a pull request to add @lotoussa! 🎉