-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More readable aws resources scan output #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats for your first PR Louis !
As Elie told me more than once, try to keep your PR as small as possible with the issue you're working on.
As for the description of your PR, I didn't understand all of what you wrote. What is SIP ? Can you "re-read" and thus edit so that we can fully understand (or maybe I'm solo on this one and shame on me to not understand ^^).
The PR title should be reworked to something clear enough to be understandable by our users (and by us) as it will be used as it in the changelog : https://github.com/cloudskiff/driftctl/releases |
Actually the issue is flagged as a new feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update stringer usage in diff output too (not only for deleted and unmanaged resources)
2d4f44c
to
67146d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 69.77% 69.79% +0.01%
==========================================
Files 215 215
Lines 4811 4813 +2
==========================================
+ Hits 3357 3359 +2
Misses 1184 1184
Partials 270 270
|
b8ea40b
to
789fa7b
Compare
I'll refresh goldenfiles another day, description PR and resolve others conversations too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way better ππ» I still have small remarks
789fa7b
to
d28dd21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ππ»
@all-contributors please add @lotoussa for code, doc |
I've put up a pull request to add @lotoussa! π |
Description
ISSUE 79: first lotoussa issue.
I first corrected the scan output of route53 resources as requested in issue 79.
Then I updated the console output (which handle aws resources output in general).
Updated the tests.
The PR is probably still in progress, because there's others aws resources containing string method that need to return either ID or adapted humanString, but i want to make a brief point of that with someone of the team.
(file concerned: aws_route_table_association_ext, aws_route_ext, aws_security_group_rule_ext)