fix: aws_lb_listener cache key #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-vanta
requested review from
muratcelep
and removed request for
a team
|
|
wbeuil
approved these changes
Nov 18, 2022
|
@all-contributors please add @martin-vanta for bug |
|
I've put up a pull request to add @martin-vanta! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the cache key for load balancer listeners to correctly include the load balancer name, so that we don't return listeners belonging to other LBs.
The tests are currently structured around testing a single method call which won't test this issue, so I extended the tests to have multiple calls. Let me know if there are existing patterns or other ways you'd prefer this done.