Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for terraform modules #150

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add support for terraform modules #150

merged 2 commits into from
Jan 27, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #142
❓ Documentation no

Description

Allow to read IaC resources from modules

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jan 25, 2021
@eliecharra eliecharra requested a review from a team January 25, 2021 14:16
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #150 (e301c0a) into main (97f992a) will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   67.76%   67.78%   +0.02%     
==========================================
  Files         186      186              
  Lines        4197     4200       +3     
==========================================
+ Hits         2844     2847       +3     
  Misses       1045     1045              
  Partials      308      308              
Impacted Files Coverage Ξ”
pkg/iac/terraform/state/terraform_state_reader.go 78.68% <85.71%> (+0.53%) ⬆️

@eliecharra eliecharra marked this pull request as ready for review January 27, 2021 11:11
Copy link
Contributor

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ†’

@eliecharra eliecharra merged commit 0938f0b into main Jan 27, 2021
@eliecharra eliecharra deleted the module_support branch January 27, 2021 19:28
@eliecharra eliecharra linked an issue Jan 27, 2021 that may be closed by this pull request
@eliecharra eliecharra added this to the v0.4.0 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Terraform Modules
2 participants