Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_route, aws_route_table, aws_default_route_table support #116

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #94 #18 #19
❓ Documentation yes

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jan 14, 2021
@eliecharra eliecharra requested a review from a team January 14, 2021 17:24
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #116 (a125839) into main (a0b2e0f) will increase coverage by 0.47%.
The diff coverage is 72.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   67.09%   67.57%   +0.47%     
==========================================
  Files         153      167      +14     
  Lines        3495     3833     +338     
==========================================
+ Hits         2345     2590     +245     
- Misses        890      959      +69     
- Partials      260      284      +24     
Impacted Files Coverage Ξ”
pkg/driftctl.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/aws/aws_default_route_table_ext.go 33.33% <33.33%> (ΓΈ)
pkg/remote/aws/route_supplier.go 52.38% <52.38%> (ΓΈ)
...s/deserializer/default_route_table_deserializer.go 53.33% <53.33%> (ΓΈ)
...kg/resource/aws/deserializer/route_deserializer.go 53.33% <53.33%> (ΓΈ)
...ource/aws/deserializer/route_table_deserializer.go 53.33% <53.33%> (ΓΈ)
pkg/resource/aws/aws_route_table_ext.go 55.55% <55.55%> (ΓΈ)
pkg/remote/aws/route_table_supplier.go 59.70% <59.70%> (ΓΈ)
pkg/middlewares/aws_route_table_expander.go 89.33% <89.33%> (ΓΈ)
... and 22 more

Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the possible race condition between both runners. Otherwise LGTM

@eliecharra eliecharra merged commit 8bbd8d4 into main Jan 15, 2021
@eliecharra eliecharra deleted the aws_route_table branch January 15, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aws_route Support aws_default_route_table Support aws_route_table
3 participants