Fix github acceptance test

[eliecharra]

Reference : integrations/terraform-provider-github#908

[codecov]

Codecov Report

Merging #1080 (73db23a) into main (65352be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1080   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files         261      261           
  Lines        8176     8176           
=======================================
  Hits         6682     6682           
  Misses       1289     1289           
  Partials      205      205           

[majormoses]

I realize this is not the upstream project. It sounds to me like we can work around the issue by specifying the name rather than the node_id but I would like to check my understanding/assumptions.

I am confused are we supposed to specify a node_id or a name? The experience as a consumer of this provider resource has been confusing. I am not sure that this is correct (in terms of the community), we are "fixing" a test by not testing an expected use case according to the documentation. If we no longer expect people to use a node_id and should only use a name then we need to update the documentation to help people understand what they are expected to change to upgrade.

https://registry.terraform.io/providers/integrations/github/latest/docs/resources/branch_protection#repository_id

(Required) The name or node ID of the repository associated with this branch protection rule.