feat: lock library dependencies #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strassl-snyk
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Changes LGTM, Snyk seems unhappy though.
I do wonder whether it would be worthwhile to have an additional CI step that tests against latest. We could even run that on a schedule. This way we could reliably distinguish between a dependency breaking and PR changes breaking. I don't want to blow up the scope for this change though.
|
@strassl-snyk great point, added it not to regress on the “surprise” end that we had so far covered as part of the existing CI. |
strassl-snyk
requested changes
Jul 26, 2023
strassl-snyk
approved these changes
Jul 26, 2023
|
🎉 This PR is included in version 4.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR locks code-client dependencies for install reproducibility purposes in the CI.
The current solution of not having a lock, doesn't address the issue that it's meant to solve, as CLI (or any other consumer) would result in a different dependency resolution than the one happening in the current library's CI pipeline.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Coffee read: https://snyk.io/blog/what-is-package-lock-json.
Discussions: https://snyk.slack.com/archives/C0135Q8LP61/p1689183248655649
Screenshots
Additional questions