fix: getIpFamily not detecting IPv6 support #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelkaporin
force-pushed
the
fix/auth-getIpFamily
branch
from
0eda36a to
c544dc2
Compare
ArtsiomCh
reviewed
Dec 24, 2021
ArtsiomCh
reviewed
Dec 24, 2021
|
failed tests in CI? |
@ArtsiomCh haven't changed anything around the code that fails, thus I assume it's the same issue that happens from time to time due to backend Snyk Code changes. It's out of scope of this PR to fix, unless Sast team asks me to 😄 |
ArtsiomCh
approved these changes
Dec 24, 2021
saark-snyk
approved these changes
Jan 3, 2022
saark-snyk
reviewed
Jan 3, 2022
|
This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.
|
michelkaporin
force-pushed
the
fix/auth-getIpFamily
branch
from
aa90768 to
94e54b7
Compare
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes regression that got introduced as part of this PR, where try/catch was removed within
getIpFamilyfunction.This led to all users that support IPv6 default to IPv4 protocol when authenticating through IDE, since the
verify/callbackalways returns 401 at this point (i.e.res.success = false).Since the new code doesn't bubble errors up to the caller, added additional map for the exception that gets thrown when IPv6 lookup is not supported by a user.
Any background context you want to provide?
https://github.com/snyk/vscode-extension/issues/116