Feat/legacy json support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2021
pkey
reviewed
Sep 27, 2021
pkey
reviewed
Sep 27, 2021
pkey
approved these changes
Sep 27, 2021
Arvi3d
force-pushed
the
feat/legacy-json-support
branch
2 times, most recently
from
bf56e00 to
7412e89
Compare
removed yalc and updated doc with recommendation to use npm link instead
Arvi3d
force-pushed
the
feat/legacy-json-support
branch
from
7412e89 to
0d6b683
Compare
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -78,10 +78,10 @@ export async function makeRequest(payload: Payload): Promise<{ success: boolean; | |||
| do { | |||
| try { | |||
| response = await needle(method, url, data, options); | |||
| emitter.apiRequestLog(`<= Response: ${response.statusCode} ${JSON.stringify(response.body)}`.slice(0, 399)); | |||
| emitter.apiRequestLog(`<= Response: ${response.statusCode} ${JSON.stringify(response.body)}`); | |||
There was a problem hiding this comment.
Seeing this in the console since update:
There was a problem hiding this comment.
ah, i probably forgot to limit it inside vsc.
The idea was that we need to be able to debug this data.
And i was going to do this limiting inside vsc.
There was a problem hiding this comment.
@Arvi3d got it, thanks. I'll do it on VSC side myself 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a pre-requisite to update VSC to use new Code API, instead of the old one.
analysis option now accepts a new key legacy?: boolean to control results' format.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots
Additional questions