fix: container optional python dependencies #5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See snyk/snyk-docker-plugin#614 Fixing a bug in snyk-docker-plugin so that optional dependencies are properly connected in the dep-graph. This could mean that 'snyk container monitor' commands that previously timed out or errored may now start working. The fix reduces unnecessary (optional) paths in the dep-graph and so reduce the work Snyk needs to do when scanning for vulnerabilities.
sandor-trombitas
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
See snyk/snyk-docker-plugin#614
Fixing a bug in snyk-docker-plugin so that optional dependencies are properly connected in the dep-graph.
This could mean that 'snyk container monitor' commands that previously timed out or errored may now start working. The fix reduces unnecessary (optional) paths in the dep-graph and so reduce the work Snyk needs to do when scanning for vulnerabilities.
How should this be manually tested?
snyk container monitoron a docker image using requirements.txt to install python dependencies.