fix: check if cachedir is empty #4367
Conversation
| if len(c.CacheDirectory) > 0 { | ||
| // ensure the specified base cache directory exists, this needs to be done even before acquiring the lock | ||
| if _, err = os.Stat(c.CacheDirectory); os.IsNotExist(err) { | ||
| err = os.Mkdir(c.CacheDirectory, local_utils.CACHEDIR_PERMISSION) |
There was a problem hiding this comment.
maybe use mkdirall?
There was a problem hiding this comment.
I would, but we are having a bit of a hen-egg situation. We need the cache directory to create the lock file in, but at the same time we want protect the filesystem operations with the lock file. Originally I didn't even want to do mkdir here, but acceptance tests showed that this was necessary to remain backwards compatible. Sure it could be that multiple folders would need to be created, but again this would cause issues since mkdirall is not an atomic operation.
There was a problem hiding this comment.
Solution could be to create the lock file outside of the cache directory, but this would increase our foot print in the file system and could potentially cause issues during deployment.
What does this PR do?