-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable container app scan with feature flag #4105 #4224
Conversation
|
This commit adds a check for the `containerCliAppVulnsEnabled` feature flag. If neither `--exclude-app-vulns` nor `--app-vulns` are set, the feature flag will be used to determine whether app vulnerabilities will be scanned or not.
a37699c
to
b12216d
Compare
// TODO: we should be able to remove that setting once once we remove the | ||
// containerCliAppVulnsEnabled feature flag has been removed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New TODO comment introduced here:
// TODO: we should be able to remove that setting once once we remove the
// containerCliAppVulnsEnabled feature flag has been removed as well.
// Currently without setting this (or app-vulns), the code tries to reach
// the API to check the feature flag and throws an exception.
Consider fixing it now or converting it into an issue to raise visibility.
Mention [stepsize] in a comment to create an issue out of this TODO. See examples here.
// TODO: we should be able to remove that setting once once we remove the | ||
// containerCliAppVulnsEnabled feature flag has been removed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New TODO comment introduced here:
// TODO: we should be able to remove that setting once once we remove the
// containerCliAppVulnsEnabled feature flag has been removed as well.
// Currently without setting this (or app-vulns), the code tries to reach
// the API to check the feature flag and throws an exception.
Consider fixing it now or converting it into an issue to raise visibility.
Mention [stepsize] in a comment to create an issue out of this TODO. See examples here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
What does this PR do?
This commit adds a check for the
containerCliAppVulnsEnabled
feature flag. If neither--exclude-app-vulns
nor--app-vulns
are set, the feature flag will be used to determine whether app vulnerabilities will be scanned or not.This commit was merged in #4105 and reverted in #4184 again due to an issue with the global-agent patch.
This PR now builds on top of #4205 instead.