chore: upgrade pkg from 5.6.0 to 5.8.0

Signed-off-by: Peter Schäfer <[email protected]> chore: upgrade depcheck from 1.4.1 to 1.4.3 … resolves issue of false positive unused dependencies when running `npx ts-node ./scripts/check-dependencies.ts` Signed-off-by: Peter Schäfer <[email protected]> chore: pin pkg to the exact version Signed-off-by: Peter Schäfer <[email protected]> chore: update nodejs 16.14.2 to 16.16.0 Signed-off-by: Peter Schäfer <[email protected]> chore: disable sudo since the new docker node image … … doesn’t support it Signed-off-by: Peter Schäfer <[email protected]> chore: inverse default value of ‘npm_global_sudo’ and adapt usage Signed-off-by: Peter Schäfer <[email protected]> chore: update nodejs versions 14.19.1 to 14.20.0 Signed-off-by: Peter Schäfer <[email protected]> chore: extend jest matrix test Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]>
snyk · Aug 31, 2022 · 3f93319 · 3f93319
1 parent 9f69ced
commit 3f93319
Show file tree

Hide file tree

Showing 9 changed files with 314 additions and 171 deletions.
diff --git a/.circleci/chocolatey.config b/.circleci/chocolatey.config
@@ -4,7 +4,7 @@
     <package id="gradle" version="6.8.3" />
     <package id="sbt" version="1.5.5" />
     <package id="awscli" version="2.4.12" />
-    <package id="nodejs" version="16.14.2" />
+    <package id="nodejs" version="16.16.0" />
     <package id="go" version="1.18.2" />
     <package id="mitmproxy" version="7.0.4" />
 </packages>
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -14,7 +14,7 @@ parameters:
   node_version:
     type: string
     # https://circleci.com/developer/images/image/cimg/node
-    default: '16.14.2'
+    default: '16.16.0'
   npm_version:
     type: string
     # match whatever's bundled with node_version
@@ -74,7 +74,7 @@ commands:
         default: /mnt/ramdisk/.npm
       npm_global_sudo:
         type: boolean
-        default: true
+        default: false
       npm_install:
         type: boolean
         default: false
@@ -335,7 +335,6 @@ jobs:
           at: .
       - install_sdks_windows
       - setup_npm:
-          npm_global_sudo: false
           npm_install: true # reinstalling as workspace node_modules is for linux
           npm_cache_directory: ~\AppData\Local\npm-cache
       - run:
@@ -358,7 +357,6 @@ jobs:
           at: .
       - install_sdks_macos
       - setup_npm:
-          npm_global_sudo: false
           npm_install: true # reinstalling as workspace node_modules is for linux
           npm_cache_directory: /Users/distiller/.npm
       - run:
@@ -387,6 +385,7 @@ jobs:
             sudo apt install nodejs npm
       - setup_npm:
           npm_cache_directory: /home/circleci/.npm
+          npm_global_sudo: true
       - run:
           name: Configuring artifact
           command: << parameters.test_snyk_command >> config set "api=${SNYK_API_KEY}"
@@ -413,6 +412,7 @@ jobs:
             sudo apt install nodejs npm
       - setup_npm:
           npm_cache_directory: /home/circleci/.npm
+          npm_global_sudo: true
       - run:
           name: Configuring artifact
           command: << parameters.test_snyk_command >> config set "api=${SNYK_API_KEY}"
@@ -425,6 +425,8 @@ jobs:
     parameters:
       node_version:
         type: string
+      npm_global_sudo:
+        type: boolean
     executor:
       name: docker-node
       node_version: << parameters.node_version >>
@@ -439,6 +441,7 @@ jobs:
           at: .
       - install_sdks_linux
       - setup_npm:
+          npm_global_sudo: << parameters.npm_global_sudo >>
           node_version: << parameters.node_version >>
       - run:
           name: Configuring Snyk CLI
@@ -805,7 +808,15 @@ workflows:
             - Build
           matrix:
             parameters:
-              node_version: ['12.22.11', '14.19.1', '16.14.2']
+              node_version: ['12.22.11', '14.20.0', '16.16.0']
+              npm_global_sudo: [true, false]
+            exclude:
+              - node_version: '12.22.11'
+                npm_global_sudo: false
+              - node_version: '14.20.0'
+                npm_global_sudo: false
+              - node_version: '16.16.0'
+                npm_global_sudo: true
       - test-tap:
           name: Tap Tests
           context: nodejs-install
@@ -894,8 +905,8 @@ workflows:
             - Lint
             - Tap Tests
             - Jest Tests (Node v12.22.11)
-            - Jest Tests (Node v14.19.1)
-            - Jest Tests (Node v16.14.2)
+            - Jest Tests (Node v14.20.0)
+            - Jest Tests (Node v16.16.0)
             - Acceptance Tests (snyk-win.exe)
             - Acceptance Tests (snyk-macos)
             - Acceptance Tests (snyk-linux)

diff --git a/.github/workflows/check-dependencies.yml b/.github/workflows/check-dependencies.yml
@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: '16.14.2'
+          node-version: '16.16.0'
           cache: 'npm'
       - run: npm ci
       - run: npx ts-node ./scripts/check-dependencies.ts
diff --git a/.github/workflows/cli-alert.yml b/.github/workflows/cli-alert.yml
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: '16.14.2'
+          node-version: '16.16.0'
           cache: 'npm'
       - run: npm ci
       - run: npm start

diff --git a/.github/workflows/danger-zone.yml b/.github/workflows/danger-zone.yml
@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: '16.14.2'
+          node-version: '16.16.0'
           cache: 'npm'
       - run: npm ci
       - run: npx danger ci

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.14.2
+16.16.0
diff --git a/docker-desktop/build.sh b/docker-desktop/build.sh
@@ -3,7 +3,7 @@ set -euo pipefail
 
 platform="${1}"
 arch="${2}"
-node_version="v16.14.2"
+node_version="v16.16.0"
 node_url="https://nodejs.org/dist/${node_version}/node-${node_version}-${platform}-${arch}.tar.gz"
 build_name="snyk-for-docker-desktop-${platform}-${arch}"
 build_filename="${build_name}.tar.gz"