Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Priority score of an issue is not displayed #207

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

winterji
Copy link
Contributor

This PR fixes the issue I raised - #206

No priority scores were displayed for project's issues.

What this does

Adds another location within the json response from snyk where to get the value of a priority score of an issue.

Notes for the reviewer

See commit changes - added a new attribute of an issue to unifiedIssuesTypes.ts and referenced the new location in SnykIssuesComponent.tsx.

jwinter added 3 commits November 14, 2024 12:40
added risk key into the defined type for IssueAttributes
@stefanbuck-snyk
Copy link
Collaborator

Thank you for your contribution! 🙌

I reviewed the changes, and everything looks good overall. However, I noticed one issue: the column is currently named priority score, but in reality, it could represent either priority or risk score. Unfortunately, there’s no way to distinguish this from the API response at the moment.

To make it clearer, how about renaming the column to priority/risk score? Let me know what you think!

@winterji
Copy link
Contributor Author

winterji commented Nov 21, 2024

Thank you for your review!

I understand. What if we named it just "Score" then? Snyk also displays it just as score - see attached image.
snyk-screenshot-issue-example

However, "Priority/Risk Score" would also work, but just "Score" could save some space in the table.

@stefanbuck-snyk
Copy link
Collaborator

Agreed, using just 'Score' is a better choice as it aligns with how it's labeled in our app and also less clutter in the table.

@winterji
Copy link
Contributor Author

I renamed the column in the last commit. If I forgot about something, let me know.

@stefanbuck-snyk
Copy link
Collaborator

I’d like to pull and test these changes in our Backstage installation before merging, just to ensure everything works as expected.

@stefanbuck-snyk stefanbuck-snyk merged commit fb8393e into snyk-tech-services:main Nov 21, 2024
@stefanbuck-snyk
Copy link
Collaborator

The release pipeline is currently broken and needs to be fixed first. I’ll work on getting this resolved asap

@winterji
Copy link
Contributor Author

Ok. Thanks for approving and merging it. Let me know when you'll release new version with these updates, so I can update it in our backstage.

@stefanbuck-snyk
Copy link
Collaborator

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants