Resolve environment variables in hocon #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @shin-nien! Can you sign our CLA please: https://github.com/snowplow/snowplow/wiki/CLA |
|
yep - cool all signed! |
|
related to snowplow snowplow/snowplow#2798 |
|
Confirmed, @shin-nien has signed the CLA. Thanks so much! |
|
The same changes have made their way into the Snowplow Steller's Sea Eagle release - so it'd be great to get a new release here to stay in sync. Ta. |
alexanderdean
changed the title
|
Any news on this merge? |
|
We'd also benefit from this merge as we're building the Dockerfiles to run the real-time pipeline, and would like to use environment variables |
|
Sure thing both, we are going to strip back the 0.5.0 milestone (keeping this ticket) and bump this release's priority... |
BenFradet
changed the title
BenFradet
pushed a commit
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the using
stream-name: "my-stream-"${STREAM_POSTFIX}in config files so that environment variables can be substituted into them:STREAM_POSTFIX="production" /opt/snowplow/snowplow-kinesis-s3 --config /opt/snowplow/scala-kinesis-s3.conf