Improve Kinesis / S3 configuration to run against mock services #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2020 10:19
Define a configuration property `dynamoDBCustomEndpoint` to override DynamoDB endpoint used by the Kinesis Client Library.
Define a configuration property `pathStyleAccessEnabled` to enable path-style access to an S3 bucket. The path-style access can be used for local development against mocked services that do not support virtual-hosted access style.
dukex
reviewed
Jul 16, 2021
| # customEndpoint = {{kinesisEndpoint}} | ||
| # dynamoDBCustomEndpoint = {{kinesisEndpoint}} |
There was a problem hiding this comment.
Suggested change
| # dynamoDBCustomEndpoint = {{kinesisEndpoint}} | |
| # dynamoDBCustomEndpoint = {{dynamoDBEndpoint}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims at running the S3 loader locally against mocked services such as localstack or minio.
To be able to read from Kinesis, the KCL automatically creates a DynamoDB table to keep the stream offset. When running locally, the KCL DynamoDB endpoint should allow to be overridden through the configuration to point to a local DynamoDB.
This is done by introducing an optional
dynamoDBCustomEndpointin the Kinesis configuration. This property is then propagated to KCL configuration when it is defined.The second part of that pull request introduces a configuration property for the S3 client:
pathStyleAccessEnabled. That flag allows to enable the path-style access on the S3 client, instead of the default virtual-hosted access style, which is not necessarily supported by mocked services such as localstack.