Add browser-plugin-web-vitals to track Web Vitals metrics #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
from
f61254a to
e233ea6
Compare
BundleMonFiles added (6)
Total files change +94.92KB 0% Final result: ✅ View report in BundleMon website ➡️ |
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
2 times, most recently
from
f6285c4 to
d8957fe
Compare
jethron
reviewed
May 18, 2023
| * @remarks | ||
| */ | ||
| export function WebVitalsPlugin(pluginOptions: WebVitalsPluginOptions = defaultPluginOptions): BrowserPlugin { | ||
| const webVitalsObject: Record<string, unknown> = {}; |
There was a problem hiding this comment.
Should the type of this be more explicit, like at least Record<string, string | number>?
There was a problem hiding this comment.
Slightly funkier, but probably not worth it:
export type WebVitalsPayload = {
navigationType: Metric["navigationType"];
} & {
[f in Lowercase<Metric["name"]>]: Metric["value"];
};
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
5 times, most recently
from
5c029d1 to
9706ad2
Compare
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
from
9706ad2 to
ea0556a
Compare
igneel64
commented
May 29, 2023
jethron
approved these changes
May 30, 2023
| * @remarks | ||
| */ | ||
| export function WebVitalsPlugin(pluginOptions: WebVitalsPluginOptions = defaultPluginOptions): BrowserPlugin { | ||
| const webVitalsObject: Record<string, unknown> = {}; |
There was a problem hiding this comment.
Slightly funkier, but probably not worth it:
export type WebVitalsPayload = {
navigationType: Metric["navigationType"];
} & {
[f in Lowercase<Metric["name"]>]: Metric["value"];
};
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
2 times, most recently
from
c2a527d to
23ce30e
Compare
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
from
23ce30e to
d474283
Compare
igneel64
force-pushed
the
feature/1189-browser-plugin-web-vitals
branch
from
d474283 to
6aa80b8
Compare
igneel64
added a commit
that referenced
this pull request
Jun 20, 2023
igneel64
added a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Web Vitals plugin!
close #1189