Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema DDL: fix nullable array casting into string in BigQuery AST #461

Closed
chuwy opened this issue Dec 21, 2018 · 0 comments
Closed

Schema DDL: fix nullable array casting into string in BigQuery AST #461

chuwy opened this issue Dec 21, 2018 · 0 comments
Assignees
@chuwy
Labels
bug
Milestone
Release 11 Capul ...

Comments

@chuwy
Copy link
Contributor

chuwy commented Dec 21, 2018 •
edited
Loading

iglu/0-common/schema-ddl/src/main/scala/com.snowplowanalytics/iglu.schemaddl/bigquery/Field.scala

Line 51 in adc6775

case Some(CommonProperties.Array) =>

In order to form REPEATED field, array cannot be nullable.

It means that every ["array", "null"] will be casted into string as last resort.
@chuwy chuwy added this to the Release 12 TBC milestone Dec 21, 2018
@chuwy chuwy self-assigned this Dec 21, 2018
@chuwy chuwy added the bug label Dec 21, 2018
@chuwy chuwy changed the title Schema DDL: fix nullable array casting into string Schema DDL: fix nullable array casting into string in BigQuery AST Dec 21, 2018
@chuwy chuwy mentioned this issue Dec 21, 2018
Closed
chuwy added a commit that referenced this issue Jan 15, 2019
@chuwy
Schema DDL: fix nullable array casting into string in BigQuery AST (c…
733cc87 
…lose #461)
@chuwy chuwy closed this as completed in 76a97fa Jan 23, 2019
rzats pushed a commit to snowplow/schema-ddl that referenced this issue Mar 25, 2019
@chuwy @rzats
Fix nullable array casting into string in BigQuery AST (close snowplo…
57c2dc6 
…w/iglu#461)
@chuwy chuwy mentioned this issue Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
bug
Projects
None yet
Milestone
Release 11 Capul de bour
Development

No branches or pull requests
1 participant
@chuwy