Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cookie extractor enrichment case insensitive #877

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

peel
Copy link
Contributor

@peel peel commented Feb 19, 2024

Previously, cookie extractor enrichment was only looking for Cookie header ignoring when the header has been supplied as a lower case cookie. This caused issues with Collector 3 that follows a case-insensitive header names.
Now, both cookie and Cookie headers are matched as containing user-agent's cookie.

1 - https://www.rfc-editor.org/rfc/rfc7230#section-3.2

Previously, cookie extractor enrichment was only looking for `Cookie`
header ignoring when the header has been supplied as a lower case
`cookie`. This caused issues with Collector 3 that follows a
case-insensitive header names.
Now, both `cookie` and `Cookie` headers are matched as containing
user-agent's cookie.

1 - https://www.rfc-editor.org/rfc/rfc7230#section-3.2
@peel peel force-pushed the bug/make-cookie-extractor-case-insensitive branch from f3f4296 to 6634a3a Compare February 20, 2024 12:31
@peel peel merged commit c0d05cb into develop Feb 20, 2024
1 check passed
@peel peel deleted the bug/make-cookie-extractor-case-insensitive branch February 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants