-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SendGrid webhook: make schema configurable #791
Comments
matus-tomlein
added a commit
that referenced
this issue
May 18, 2023
matus-tomlein
added a commit
that referenced
this issue
Jun 29, 2023
Run scalafmt Add strictly typed properties for schemas in adapter configs Add adapters config to stream enrich Duplicate adapter configuration in each SpecHelpers Rmove duplicated configuration Update include_current.txt configuration in common test resources
matus-tomlein
added a commit
that referenced
this issue
Jun 30, 2023
Run scalafmt Add strictly typed properties for schemas in adapter configs Add adapters config to stream enrich Duplicate adapter configuration in each SpecHelpers Rmove duplicated configuration Update include_current.txt configuration in common test resources
matus-tomlein
added a commit
that referenced
this issue
Jul 11, 2023
Run scalafmt Add strictly typed properties for schemas in adapter configs Add adapters config to stream enrich Duplicate adapter configuration in each SpecHelpers Rmove duplicated configuration Update include_current.txt configuration in common test resources
matus-tomlein
added a commit
that referenced
this issue
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
network/json-schema-validator
library uses a manually-maintained list of TLDs to validate the emails, which can cause the emails sent via SendGrid webhook to fail validation because their domain is not known.A possible solution is to make the schema hard coded in Sendgrid adapter configurable.
Guide
Enrich has kind of 3 steps:
The configuration format (for example for Kinesis) is defined in here. We probably want to add a new section that could look like this :
There are several sbt modules:
common
contains the adapters and enrichments logic (we'll need to update it so that the adapters can become configurable)common-fs2
contains the logic related to configuring the app, reading events, writing them (we'll need to update it so that the config is propagated to the adapters)kinesis
: logic related to reading from/writing to Kinesis (we won't need to touch it)When running
enrich-kinesis
for instance, the starting point is here.It then goes here and then goes to
common-fs2
'sRun
here.It creates an
Environment
here.In our case we'll need to take the schema defined in the config and pass it to the
AdapterRegistry
here when creating theEnvironment
The text was updated successfully, but these errors were encountered: