Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrich-kinesis: Cap recordTtl in KPL #581

Closed
istreeter opened this issue Mar 25, 2022 · 0 comments
Closed

enrich-kinesis: Cap recordTtl in KPL #581

istreeter opened this issue Mar 25, 2022 · 0 comments

Comments

@istreeter
Copy link
Contributor

Until now we set the recordTtl to infinite time when configuring the Kinesis Producer. We thought it was a good idea, because we trusted KPL to retry forever.

However, we found that KPL can go into a death spiral from which it never recovers. I think this happens because KPL retries very aggressively, and it can overwhelm the network, or the Kinesis service. Worst of all, the KPL does not produce any logs while this is happening, so it looks like the app has frozen. If this happens, it would be much better for the KPL to stop retrying, and give up and let the application crash. Therefore, we should cap recordTtl to a finite value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant