Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging of collector payloads #522

Closed
istreeter opened this issue Dec 11, 2021 · 1 comment
Closed

Remove logging of collector payloads #522

istreeter opened this issue Dec 11, 2021 · 1 comment

Comments

@istreeter
Copy link
Contributor

There are three places in the code base where we potentially log event-level data: here in beam enrich, here in stream enrich and here in enrich-pubsub. That last one is a debug level, which is probably OK.

From a data governance point of view, logs are much more difficult to manage if they potentially contain customer data.

@istreeter
Copy link
Contributor Author

This issue was spotted during an investigation of CVE-2021-44228. But to be clear, this is not supposed to be our primary safeguard against that CVE. Rather, it's just something we should do anyway.

More details about CVE-2021-44228 impact on Snowplow apps on Discourse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant