Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: convert null fields in EnrichedEvent to None in PartiallyEnrichedEvent #331

Closed
istreeter opened this issue Sep 4, 2020 · 1 comment
Closed

Common: convert null fields in EnrichedEvent to None in PartiallyEnrichedEvent #331

istreeter opened this issue Sep 4, 2020 · 1 comment

Comments

@istreeter
Copy link
Contributor

This concerns the method toPartiallyEnrichedEvent

Currently, if an integer field is null, then it gets converted to Some(0) in the partially enriched event. Similarly for optional booleans and optional floats.
@benjben
Copy link
Contributor

benjben commented Sep 4, 2020

BTW I wonder if PartiallyEnrichedEvent adds value

istreeter pushed a commit that referenced this issue Sep 4, 2020
Convert null fields in EnrichedEvent to None in PartiallyEnrichedEvent (
1b5e497 
closes #331)
istreeter pushed a commit that referenced this issue Sep 4, 2020
@istreeter
Convert null fields in EnrichedEvent to None in PartiallyEnrichedEvent (
121810d 
closes #331)
chuwy pushed a commit that referenced this issue Sep 6, 2020
@chuwy
Common: convert null fields in EnrichedEvent to None in PartiallyEnri…
122b8e0 
…chedEvent (close #331)
@chuwy chuwy closed this as completed in f7ceb17 Sep 7, 2020
@chuwy chuwy mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@istreeter @benjben