Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: fix JS enrichment failing without return statement #295

Closed
chuwy opened this issue Jul 21, 2020 · 0 comments
Closed

Common: fix JS enrichment failing without return statement #295

chuwy opened this issue Jul 21, 2020 · 0 comments
Assignees
Labels
bug Something isn't working enrichment Add or fix existing enrichment
Milestone

Comments

@chuwy
Copy link
Contributor

chuwy commented Jul 21, 2020

In 1.3.0 we refactored JS enrichment to use Nashorn (#138). As a side-effect we made impossible to run JS enrichments without return statements. Although, we always recomment to use return statements and never mutate the event it's still an unwanted breaking change.

Example of enrichment failure bad row:

{
  "enrichment" : {
    "schemaKey" : "iglu:com.snowplowanalytics.snowplow/javascript_script_config/jsonschema/1-0-0",
    "identifier" : "Javascript enrichment"
  },
  "message" : {
    "error" : "Could not parse output JSON of Javascript function. Error: [null]"
  }
}
@chuwy chuwy added this to the 1.3.1 milestone Jul 21, 2020
@chuwy chuwy self-assigned this Jul 21, 2020
@chuwy chuwy added bug Something isn't working enrichment Add or fix existing enrichment labels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enrichment Add or fix existing enrichment
Projects
None yet
Development

No branches or pull requests

1 participant