Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Enable IP Lookup Enrichment for IPv6 with port number #284

Closed
oguzhanunlu opened this issue Jul 9, 2020 · 1 comment
Closed
Assignees
Labels
enrichment Add or fix existing enrichment good first issue Good for newcomers
Milestone

Comments

@oguzhanunlu
Copy link
Member

IpLookupsEnrichment.extractIpInformation(ip: String) strips port number from ip if it is IPv4 whereas it should be the case for both IPv4 and IPv6.

Not stripping port number from IPv6 address probably results in empty lookup result. It is worth confirming this hypothesis first and tackle the rest if that's the case.

One of the transitive dependencies is ipaddress which provides HostName to represent IP addresses or hostnames with port number or service name. It allows stripping port number and service name without dealing with complex, hard to manage regular expressions.

@oguzhanunlu oguzhanunlu added good first issue Good for newcomers enrichment Add or fix existing enrichment labels Jul 9, 2020
@oguzhanunlu
Copy link
Member Author

oguzhanunlu commented Jul 10, 2020

Not stripping port number from IPv6 address probably results in empty lookup result. It is worth confirming this hypothesis first and tackle the rest if that's the case.

I can confirm that's the case, including this in current milestone. IPv6 address without port number works fine but one with port number doesn't.

@oguzhanunlu oguzhanunlu added this to the 1.3.0 milestone Jul 10, 2020
@oguzhanunlu oguzhanunlu changed the title Common: Enable IP Lookup Enrichment for IPv6 Common: Enable IP Lookup Enrichment for IPv6 with port number Jul 10, 2020
@oguzhanunlu oguzhanunlu self-assigned this Jul 10, 2020
@chuwy chuwy closed this as completed in 717f232 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enrichment Add or fix existing enrichment good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant